Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hybrid cjs and esm support #34

Merged
merged 5 commits into from
Jun 25, 2024
Merged

feat: hybrid cjs and esm support #34

merged 5 commits into from
Jun 25, 2024

Conversation

Nesopie
Copy link
Contributor

@Nesopie Nesopie commented Jun 25, 2024

  • Add support for hybrid esm and cjs modules.
  • Use Uint8Array
  • Add CI

Note: slightly changed the signature of the encode function

@junderw
Copy link
Member

junderw commented Jun 25, 2024

can you add CI in a separate PR? Then we can rebase this PR on that and CI should run.

@junderw
Copy link
Member

junderw commented Jun 25, 2024

Also get rid of .travis.yml

@junderw
Copy link
Member

junderw commented Jun 25, 2024

Oh yeah, bump the major version please.

@junderw junderw merged commit 6a6965b into bitcoinjs:master Jun 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junderw junderw junderw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nesopie @junderw